[ 
https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684166#comment-16684166
 ] 

Shalin Shekhar Mangar commented on SOLR-7381:
---------------------------------------------

[~yuzhih...@gmail.com] - No, our implementation explicitly sets MDC context 
from parent threads and unsets/restores old context once the submitted task 
finishes. See ExecutorUtil.MDCAwareThreadPoolExecutor for the implementation.

> Improve Debuggability of SolrCloud using MDC
> --------------------------------------------
>
>                 Key: SOLR-7381
>                 URL: https://issues.apache.org/jira/browse/SOLR-7381
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Critical
>             Fix For: 5.2, 6.0
>
>         Attachments: SOLR-7381-forbid-threadpoolexecutor.patch, 
> SOLR-7381-submitter-stacktrace.patch, SOLR-7381-thread-names.patch, 
> SOLR-7381-thread-names.patch, SOLR-7381-thread-names.patch, SOLR-7381.patch, 
> SOLR-7381.patch
>
>
> SOLR-6673 added MDC based logging in a few places but we have a lot of ground 
> to cover.
> # Threads created via thread pool executors do not inherit MDC values and 
> those are some of the most interesting places to log MDC context.
> # We must expose node names (in tests) so that we can debug faster
> # We can expose more information via thread names so that a thread dump has 
> enough context to help debug problems in production
> This is critical to help debug SolrCloud failures.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to