Github user cbismuth commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/497#discussion_r233551529
  
    --- Diff: 
lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java ---
    @@ -100,13 +109,156 @@ public CacheHelper getCoreCacheHelper() {
     
       }
     
    +  /**
    +   * Wrapper class for another PointValues implementation that is used by 
ExitableFields.
    +   */
    +  public static class ExitablePointValues extends PointValues {
    +
    +    private final PointValues in;
    +    private final QueryTimeout queryTimeout;
    +
    +    public ExitablePointValues(PointValues in, QueryTimeout queryTimeout) {
    --- End diff --
    
    I'm not sure to understand, the `set -e` flag prevents the second Ant 
command line from being run if the `precommit` task fails, and therefore the 
latest output in my terminal is a build failure.
    
    The `set -x` (debug option) flag would add a lot noise.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to