[
https://issues.apache.org/jira/browse/LUCENE-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078549#comment-13078549
]
Adriano Crestani commented on LUCENE-2979:
------------------------------------------
Hi Phillipe,
Thanks for the patch. I just applied your patch for 3x. It looks good.
As you removed TestAttributes, can you create another junit to test whether
configuration is updated when an attribute (like CharTermAttribute) is updated,
which is basically the new functionality of the newly deprecated query parser
attributes.
> Simplify configuration API of contrib Query Parser
> --------------------------------------------------
>
> Key: LUCENE-2979
> URL: https://issues.apache.org/jira/browse/LUCENE-2979
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/other
> Affects Versions: 2.9, 3.0
> Reporter: Adriano Crestani
> Assignee: Adriano Crestani
> Labels: api-change, gsoc, gsoc2011, lucene-gsoc-11, mentor
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-2979_phillipe_ramalho_2.patch,
> LUCENE-2979_phillipe_ramalho_3.patch, LUCENE-2979_phillipe_ramalho_3.patch,
> LUCENE-2979_phillipe_ramalho_4_3x.patch,
> LUCENE-2979_phillipe_ramalho_4_trunk.patch,
> LUCENE-2979_phillipe_reamalho.patch
>
>
> The current configuration API is very complicated and inherit the concept
> used by Attribute API to store token information in token streams. However,
> the requirements for both (QP config and token stream) are not the same, so
> they shouldn't be using the same thing.
> I propose to simplify QP config and make it less scary for people intending
> to use contrib QP. The task is not difficult, it will just require a lot of
> code change and figure out the best way to do it. That's why it's a good
> candidate for a GSoC project.
> I would like to hear good proposals about how to make the API more friendly
> and less scaring :)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
