Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/501#discussion_r234496047
--- Diff: solr/core/src/java/org/apache/solr/update/AddUpdateCommand.java
---
@@ -96,12 +96,21 @@ public SolrInputDocument getSolrInputDocument() {
* Any changes made to the returned Document will not be reflected in
the SolrInputDocument, or future calls to this
* method.
* Note that the behavior of this is sensitive to {@link
#isInPlaceUpdate()}.
+ * @param withBlockId If true, then block id is forcibly added to the doc
*/
- public Document getLuceneDocument() {
+ Document getLuceneDocument(boolean withBlockId) {
--- End diff --
actually I'm not sure we actually need to overload getLuceneDocument with
this boolean after all. if "isInPlaceUpdate()" then don't add root but
otherwise add it. That'll be fine; right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
