Shawn I have added a patch to SOLR-13005 as it was a small change. The problem with SOLR-13004 Integer overflow is that in extending the code for the second level of grouping I was trying not to change code that I didn't need to be change or would impact into other parts of the system(trying to keep the changes isolated to grouping where possible). The totals(when grouping) are held in the ResponseBuilder and I was not changing it and able to hold and accumulate the totals in my new grouping code. I am not sure how much work would be involved with changing to a long, but I am busy at the moment but may be able to look at a patch later.
Ian NLA ResponseBuilder line 184 public int totalHitCount; // Hit count used when distributed grouping is performed. -----Original Message----- From: Shawn Heisey <[email protected]> Sent: Wednesday, 21 November 2018 3:58 PM To: [email protected] Subject: Re: 2 Level grouping (solr 5.5.3) On 11/20/2018 9:45 PM, Ian Caldwell wrote: > > Yes the bugs were in the std code JIRS created. > > https://issues.apache.org/jira/browse/SOLR-13004 > > https://issues.apache.org/jira/browse/SOLR-13005 > Can you attach patches to the issues that fix the problems? We will need to confirm whether the problems you found are still there in current versions -- 5.5.3 is more than a little outdated now. It is two major versions back from current, and was released two years ago. In open source terms, that's ancient. Someone else may have noticed the problems and fixed them already. Thanks, Shawn --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
