[
https://issues.apache.org/jira/browse/LUCENE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697658#comment-16697658
]
Tomoko Uchida commented on LUCENE-2562:
---------------------------------------
Some improvements in the pull request:
1. The luke module passed ant precommit.
I examined the Javadoc linter scripts and found that excluding a specific
module when executing {{documentation-lint}} is not allowed for now. I added
missing javadocs to pass linter's check so that {{ant precommit}} is
successfully built.
2. JVM warnings when running on JDK9+ was resolved.
The warnings ("An illegal reflective access operation") was not a compatibility
issue of Guice. Guice works fine with JDK9+. I added {{--add-opens}} JVM option
in the start script to allow deep reflection. By doing so, dependency injection
works within the module system and the warnings disappears.
3. A start script for windows was added.
{{luke.bat}} was added for windows os.
Is there anything else I can do for this issue? ;D
> Make Luke a Lucene/Solr Module
> ------------------------------
>
> Key: LUCENE-2562
> URL: https://issues.apache.org/jira/browse/LUCENE-2562
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Mark Miller
> Priority: Major
> Labels: gsoc2014
> Attachments: LUCENE-2562-Ivy.patch, LUCENE-2562-Ivy.patch,
> LUCENE-2562-Ivy.patch, LUCENE-2562-ivy.patch, LUCENE-2562.patch,
> LUCENE-2562.patch, Luke-ALE-1.png, Luke-ALE-2.png, Luke-ALE-3.png,
> Luke-ALE-4.png, Luke-ALE-5.png, luke-javafx1.png, luke-javafx2.png,
> luke-javafx3.png, luke1.jpg, luke2.jpg, luke3.jpg, lukeALE-documents.png,
> スクリーンショット 2018-11-05 9.19.47.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> see
> "RE: Luke - in need of maintainer":
> http://markmail.org/message/m4gsto7giltvrpuf
> "Web-based Luke": http://markmail.org/message/4xwps7p7ifltme5q
> I think it would be great if there was a version of Luke that always worked
> with trunk - and it would also be great if it was easier to match Luke jars
> with Lucene versions.
> While I'd like to get GWT Luke into the mix as well, I think the easiest
> starting point is to straight port Luke to another UI toolkit before
> abstracting out DTO objects that both GWT Luke and Pivot Luke could share.
> I've started slowly converting Luke's use of thinlet to Apache Pivot. I
> haven't/don't have a lot of time for this at the moment, but I've plugged
> away here and there over the past work or two. There is still a *lot* to do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
