[ 
https://issues.apache.org/jira/browse/LUCENE-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080354#comment-13080354
 ] 

Steven Rowe commented on LUCENE-3361:
-------------------------------------

The {{jflex}} target depends on the {{clean-jflex}} target, which deletes all 
{{src/.../standard/*.java}} files whose contents match regex 
{{/generated.*by.*JFlex/}}.  Your patch leaves intact the first line of 
{{UAX29URLEmailTokenizer.java}}, which matches the regex in a comment.  As a 
result, running {{ant jflex}} deletes {{UAX29URLEmailTokenizer.java}}, and 
since it's no longer generated by JFlex, compilation fails.

When I remove this JFlex comment line from {{UAX29URLEmailTokenizer.java}}, 
{{ant jflex}} works, everything compiles, and all tests succeed.  +1 to commit 
after removing this line.

> port url+email tokenizer to standardtokenizerinterface (or similar)
> -------------------------------------------------------------------
>
>                 Key: LUCENE-3361
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3361
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/analysis
>    Affects Versions: 3.3
>            Reporter: Robert Muir
>         Attachments: LUCENE-3361.patch
>
>
> We should do this so that we can fix the LUCENE-3358 bug there, and preserve 
> backwards.
> We also want this mechanism anyway, for upgrading to new unicode versions in 
> the future.
> We can regenerate the new TLD list for 3.4 but, we should ensure the existing 
> one is used for the urlemail33 or whatever,
> so that its exactly the same.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to