[ https://issues.apache.org/jira/browse/SOLR-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16711410#comment-16711410 ]
Jan Høydahl commented on SOLR-13035: ------------------------------------ Looks scary to do {{SOLR_LOGS_DIR="$(pwd)/$SOLR_LOGS_DIR"}}. It would be better to require user to configure absolute path here. Why are you changing the default location of logs from SOLR_TIP/server/logs to SOLR_HOME/logs, i.e. SOLR_TIP/server/solr/logs? Also the installer script explicitly configures SOLR_LOGS_DIR to /var/solr/logs, and not to /var/solr/data/logs as would be the equivalent if it belongs inside SOLR_HOME? I agree on the goal of making Solr more container friendly and clearly separate what paths can be made R/O and what paths typically need a separate volume mounted. Can you perhaps create a diagram that clearly shows the various directory paths we have today with their defaults and how they will be changed? While I believe solr.xml could be created if not exist, I'm no so sure we should go create SOLR_DATA_HOME if it does not exist? In general, I'd prefer of much of the logic regarding folder resolution etc was done in the common {{SolrCLI.java}} so as little logic as possible needs to be duplicated in bin/solr and bin/solr.cmd > Utilize solr.data.home / solrDataHome in solr.xml to set all writable files > in single directory > ----------------------------------------------------------------------------------------------- > > Key: SOLR-13035 > URL: https://issues.apache.org/jira/browse/SOLR-13035 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Amrit Sarkar > Priority: Major > Attachments: SOLR-13035.patch > > > {{solr.data.home}} system property or {{solrDataHome}} in _solr.xml_ is > already available as per SOLR-6671. > The writable content in Solr are index files, core properties, and ZK data if > embedded zookeeper is started in SolrCloud mode. It would be great if all > writable content can come under the same directory to have separate READ-ONLY > and WRITE-ONLY directories. > It can then also solve official docker Solr image issues: > https://github.com/docker-solr/docker-solr/issues/74 > https://github.com/docker-solr/docker-solr/issues/133 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org