[
https://issues.apache.org/jira/browse/LUCENE-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080928#comment-13080928
]
Dawid Weiss commented on LUCENE-3298:
-------------------------------------
This looks good, James. The thing is: a 2GB fst is actually quite huge; until
we can realistically hit such sizes it makes little sense to replace the code
to operate on longs instead of ints and add an intermediate layer between the
byte[] that stores fst data. I believe this will affect performance, even on
64-bit systems and on 32-bit systems performance degradation will be
significant.
This said, your patch can reside in jira and wait until people hit the 2gb
barier -- when this happens, I'm sure it'll be useful.
> FST has hard limit max size of 2.1 GB
> -------------------------------------
>
> Key: LUCENE-3298
> URL: https://issues.apache.org/jira/browse/LUCENE-3298
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/FSTs
> Reporter: Michael McCandless
> Priority: Minor
> Attachments: LUCENE-3298.patch
>
>
> The FST uses a single contiguous byte[] under the hood, which in java is
> indexed by int so we cannot grow this over Integer.MAX_VALUE. It also
> internally encodes references to this array as vInt.
> We could switch this to a paged byte[] and make the far larger.
> But I think this is low priority... I'm not going to work on it any time soon.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
