[ https://issues.apache.org/jira/browse/LUCENE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717035#comment-16717035 ]
Karl Wright commented on LUCENE-8587: ------------------------------------- What I'd like to do is change the GeoPoint serialization and deserialization to save the (x,y,z) tuples rather than the (lat,lon) ones: {code} @Override public void write(final OutputStream outputStream) throws IOException { SerializableObject.writeDouble(outputStream, x); SerializableObject.writeDouble(outputStream, y); SerializableObject.writeDouble(outputStream, z); } {code} and {code} public GeoPoint(final PlanetModel planetModel, final InputStream inputStream) throws IOException { // Note: this relies on left-right parameter execution order!! Much code depends on that though and // it is apparently in a java spec: https://stackoverflow.com/questions/2201688/order-of-execution-of-parameters-guarantees-in-java this(planetModel, SerializableObject.readDouble(inputStream), SerializableObject.readDouble(inputStream), SerializableObject.readDouble(inputStream)); } {code} This is not a backwards compatible change, however, so we could make it only in master and not pull it up to the 7.x and 6.x branches. [~ivera], what do you think? > Self comparison bug in GeoComplexPolygon.equals method > ------------------------------------------------------ > > Key: LUCENE-8587 > URL: https://issues.apache.org/jira/browse/LUCENE-8587 > Project: Lucene - Core > Issue Type: Bug > Components: modules/spatial3d > Affects Versions: 7.1 > Reporter: Zsolt Gyulavari > Assignee: Karl Wright > Priority: Major > Attachments: LUCENE-8587.patch > > > GeoComplexPolygon.equals method checks equality with own testPoint1 field > instead of the other.testPoint1. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org