[ https://issues.apache.org/jira/browse/LUCENE-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082011#comment-13082011 ]
Robert Muir commented on LUCENE-3357: ------------------------------------- I wouldn't worry about the scores being negative necessarily myself: there is nothing wrong with this. But we should fix the Nan/Inf score problems. Also: some of the stats that are newer in Lucene will get stupid results with PreFlex codec, it doesnt support them. In my opinion add the following to the test's setup: {noformat} assumeFalse("test cannot run with PreFlex codec !", "PreFlex".equals(CodecProvider.getDefault().getDefaultFieldCodec())); {noformat} and I can help in the places where EasySim collects these stats, for example I think we should add checks in case totalTermFreq = -1, and throw UOE here instead. > Unit and integration test cases for the new Similarities > -------------------------------------------------------- > > Key: LUCENE-3357 > URL: https://issues.apache.org/jira/browse/LUCENE-3357 > Project: Lucene - Java > Issue Type: Sub-task > Components: core/query/scoring > Affects Versions: flexscoring branch > Reporter: David Mark Nemeskey > Assignee: David Mark Nemeskey > Priority: Minor > Labels: gsoc, gsoc2011, test > Fix For: flexscoring branch > > Attachments: LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, > LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch > > > Write test cases to test the new Similarities added in > [LUCENE-3220|https://issues.apache.org/jira/browse/LUCENE-3220]. Two types of > test cases will be created: > * unit tests, in which mock statistics are provided to the Similarities and > the score is validated against hand calculations; > * integration tests, in which a small collection is indexed and then > searched using the Similarities. > Performance tests will be performed in a separate issue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org