Github user tokee commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/525#discussion_r242875578
  
    --- Diff: 
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
 ---
    @@ -1204,6 +1204,12 @@ public void testRandomSortedBytes() throws 
IOException {
       }
     
       private void doTestNumericsVsStoredFields(double density, LongSupplier 
longs) throws Exception {
    +    doTestNumericsVsStoredFields(density, longs, 256);
    +    // TODO: 200000 docs are needed to test jumps properly (see 
LUCENE-8585), but that is quite slow (few minutes).
    +    // Maybe it can be nightly?
    +    //doTestNumericsVsStoredFields(density, longs, 200000);
    --- End diff --
    
    Should we add a `if (TEST_NIGHTLY) ...`-switch here to to enable the 200K 
test case? It would increase coverage for jumps a great deal.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to