Github user jpountz commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/525#discussion_r243648602
  
    --- Diff: 
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
 ---
    @@ -1204,6 +1204,12 @@ public void testRandomSortedBytes() throws 
IOException {
       }
     
       private void doTestNumericsVsStoredFields(double density, LongSupplier 
longs) throws Exception {
    +    doTestNumericsVsStoredFields(density, longs, 256);
    +    // TODO: 200000 docs are needed to test jumps properly (see 
LUCENE-8585), but that is quite slow (few minutes).
    +    // Maybe it can be nightly?
    +    //doTestNumericsVsStoredFields(density, longs, 200000);
    --- End diff --
    
    Let's not do that in the base test case as this will be too slow with some 
codecs such as the SimpleTextCodec. What we have done before for formats that 
have branches that only get triggered with many documens is that we added tests 
to their own test file, ie. TestLucene80DocValuesFormat.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to