[
https://issues.apache.org/jira/browse/LUCENE-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730210#comment-16730210
]
Michael McCandless commented on LUCENE-8601:
--------------------------------------------
Thanks [~muralikpbhat]!
Maybe add javadocs about {{ignoreCurrentFormat}} parameter?
Can you use multi-line {{if}} statement instead of ternary operator?
I think the changes to {{PerFieldPostingsFormat}} are OK, except instead of
removing the check that there was no format there and blindly overwriting it,
can you change that to check that either it wasn't there (what it checks now)
or, if it is there, that the value for the attributes match what that postings
format wants to write?
No need to initialize class members with {{= null}}; that's already the default
for java.
In {{DefaultIndexingChain}} can you use a local variable for the
{{fieldType.getAttributes()}} in the two places where you reference it?
> Adding attributes to IndexFieldType
> -----------------------------------
>
> Key: LUCENE-8601
> URL: https://issues.apache.org/jira/browse/LUCENE-8601
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 7.5
> Reporter: Murali Krishna P
> Priority: Major
> Attachments: LUCENE-8601.01.patch, LUCENE-8601.02.patch,
> LUCENE-8601.03.patch, LUCENE-8601.04.patch, LUCENE-8601.05.patch,
> LUCENE-8601.patch
>
>
> Today, we can write a custom Field using custom IndexFieldType, but when the
> DefaultIndexingChain converts [IndexFieldType to
> FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java#L662],
> only few key informations such as indexing options and doc value type are
> retained. The [Codec gets the
> FieldInfo|https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L90],
> but not the type details.
>
> FieldInfo has support for ['attributes'|
> https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/FieldInfo.java#L47]
> and it would be great if we can add 'attributes' to IndexFieldType also and
> copy it to FieldInfo's 'attribute'.
>
> This would allow someone to write a custom codec (extending docvalueformat
> for example) for only the 'special field' that he wants and delegate the rest
> of the fields to the default codec.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
