[ 
https://issues.apache.org/jira/browse/LUCENE-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084080#comment-13084080
 ] 

Robert Muir commented on LUCENE-3357:
-------------------------------------

I think the change to D is fine? what about the rest of the equation? 
(especially the variable "D") 

I tested D and its fine with this change, however with some of the other sims 
the changes had some negative effect... lets figure out D for now.

Also as far as the values if you omit stuff: i don't think we should provide 
fake values that seem plausible: remember if you omit term frequencies such 
that totalTermFreq is unavailable, then freq will always be 1 :)

> Unit and integration test cases for the new Similarities
> --------------------------------------------------------
>
>                 Key: LUCENE-3357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3357
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring
>    Affects Versions: flexscoring branch
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>            Priority: Minor
>              Labels: gsoc, gsoc2011, test
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, 
> LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, 
> LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, 
> LUCENE-3357.patch
>
>
> Write test cases to test the new Similarities added in 
> [LUCENE-3220|https://issues.apache.org/jira/browse/LUCENE-3220]. Two types of 
> test cases will be created:
>  * unit tests, in which mock statistics are provided to the Similarities and 
> the score is validated against hand calculations;
>  * integration tests, in which a small collection is indexed and then 
> searched using the Similarities.
> Performance tests will be performed in a separate issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to