[ 
https://issues.apache.org/jira/browse/SOLR-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084918#comment-13084918
 ] 

Ryan McKinley commented on SOLR-2657:
-------------------------------------

Thanks for looking into this hoss.  Yes, i the crux of this is the support for: 
score==*,score

I can get your tests to pass with:
{code:java}
    if( fields.size() == 1 && _wantsScore && augmenters.size() == 1 && 
globs.isEmpty() ) {
      _wantsAllFields = true;
    }
{code}

but i think the better solution is to not deprecate score==*,score

- - - - -

re okFieldNames vs fields.  The differece is that fields are the lucene field 
names that get returned from the SolrIndexSearcher -- okFieldNames is the set 
of things that the ResponseWriters check before returning a field.

I'll go ahead and commit this, and we can discuss deprecating the score syntax 
in a new issue.

I'll also take a quick pass at adding comments and cleaning things up a bit in 
ReturnFields.






> All fields returned if only psuedo fields are requested
> -------------------------------------------------------
>
>                 Key: SOLR-2657
>                 URL: https://issues.apache.org/jira/browse/SOLR-2657
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Hoss Man
>             Fix For: 4.0
>
>         Attachments: SOLR-2657-test.patch, SOLR-2657-test.patch
>
>
> Koji mentioned this in a comment in SOLR-1298...
> * {{fl=}} .. returns all stored fields (expected, backcompat)
> * {{fl=*}} .. returns all stored fields (expected, backcompat)
> * {{fl=score,*}} .. returns the score psuedo field and all stored fields 
> (expected, backcompat)
> * {{fl=score}} .. returns the score psuedo field and all stored fields 
> (expected, backcompat)
> * {{fl=score,price}} .. returns the score psuedo field and the stored price 
> field (expected, backcompat)
> * {{fl=log(price)}} .. returns the log(price) psuedo field (expected)
> * {{fl=score,log(price)}} .. returns the score and log(price) psuedo fields 
> as well as *all* of the stored fields (*NOT EXPECTED*)
> The problem seems to be that when the entire fl is made up of psuedo fields, 
> and one of them is score, the legacy behavior for an fl of only score is used 
> (instead of recognizing that other "fields" were requested, so we should not 
> output all stored fields

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to