[
https://issues.apache.org/jira/browse/LUCENE-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747805#comment-16747805
]
Adrien Grand commented on LUCENE-8649:
--------------------------------------
Thanks Ignacio, it looks good to me, I just have two minor comments:
- Maybe rename visitor2 to disjointVisitor since it seems to always be the
visitor that collects disjoint triangles (and then maybe keep the first visitor
called visitor rather than visitor1).
- cost() is supposed to be an estimation of the match count, so it should
probably return visitor2.cost() if the relation is DISJOINT and
visitor1.count() instead?
> LatLonShape: Within and disjoint queries don’t work with indexed multishapes
> ----------------------------------------------------------------------------
>
> Key: LUCENE-8649
> URL: https://issues.apache.org/jira/browse/LUCENE-8649
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/sandbox
> Reporter: Ignacio Vera
> Priority: Major
> Attachments: LUCENE-8649.patch, LUCENE-8649.patch, LUCENE-8649.patch
>
>
> Within and disjoint queries return wrong results (false positives) when
> querying for fields containing more than one shape. For example, a
> multipolygon will return true for a within query if some of the polygons are
> within and the other are disjoint. The same query will return true for
> disjoint.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
