[ https://issues.apache.org/jira/browse/SOLR-13156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753591#comment-16753591 ]
Lucene/Solr QA commented on SOLR-13156: --------------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 42s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 2m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate ref guide {color} | {color:green} 2m 41s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 2s{color} | {color:red} core in the patch failed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 90m 25s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | solr.cloud.TestCloudRecovery2 | | | solr.cloud.autoscaling.sim.TestSimExtremeIndexing | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | SOLR-13156 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956510/SOLR-13156.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns validaterefguide | | uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / 8e69d12 | | ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 | | Default Java | 1.8.0_191 | | unit | https://builds.apache.org/job/PreCommit-SOLR-Build/271/artifact/out/patch-unit-solr_core.txt | | Test Results | https://builds.apache.org/job/PreCommit-SOLR-Build/271/testReport/ | | modules | C: solr solr/core solr/solr-ref-guide U: solr | | Console output | https://builds.apache.org/job/PreCommit-SOLR-Build/271/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Limiting field facet with certain terms via {!terms} not taking into account > sorting > ------------------------------------------------------------------------------------ > > Key: SOLR-13156 > URL: https://issues.apache.org/jira/browse/SOLR-13156 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: Facet Module > Reporter: Konstantin Perikov > Assignee: Mikhail Khludnev > Priority: Major > Attachments: SOLR-13156.patch, SOLR-13156.patch > > > When I'm doing limiting facet keys with \{!terms} it doesn't take into > account sorting. > First query not limiting the facet keys: > {{facet.field=title&facet.sort=count&facet=on&q=*:*}} > Response as expected: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "book2",3, "book1",2, "book3",1]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{}}}}} > > When doing it with limiting: > {{facet.field=\{!terms=Book3,Book2,Book1}title&facet.sort=count&facet=on&q=*:*}} > I'm getting the exact order of how I list terms: > {{"facet_counts":\{ "facet_queries":{}, "facet_fields":\{ "title":[ > "Book3",1, "Book2",3, "Book1",2]}, "facet_ranges":{}, "facet_intervals":{}, > "facet_heatmaps":{}}}}} > I've looked at the code, and it's clearly an issue there: > > org.apache.solr.request.SimpleFacets#getListedTermCounts > > {{for (String term : terms) {}} > {{ int count = searcher.numDocs(ft.getFieldQuery(null, sf, term), > parsed.docs);}} > {{ res.add(term, count);}} > {{}}} > > it's just basically iterating over terms and don't do any sorting at all. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org