[ https://issues.apache.org/jira/browse/LUCENE-8660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753872#comment-16753872 ]
Adrien Grand commented on LUCENE-8660: -------------------------------------- Thanks [~jim.ferenczi]. I think we also need to update javadocs and the range of accepted values from [1, MAX_VALUE] to [0, MAX_VALUE]? > Include totalHitsThreshold when tracking total hits in TopDocsCollector > ----------------------------------------------------------------------- > > Key: LUCENE-8660 > URL: https://issues.apache.org/jira/browse/LUCENE-8660 > Project: Lucene - Core > Issue Type: Bug > Reporter: Jim Ferenczi > Priority: Minor > Attachments: LUCENE-8660.patch > > > Today the total hits threshold in the top docs collector is not inclusive, > this means that total hits are tracked up to totalHitsThreshold-1. After > discussing with @jpountz we agreed that this is not intuitive to return a > lower bound that is equal to totalHitsThreshold even if the count is accurate. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org