[ 
https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754367#comment-16754367
 ] 

David Smiley commented on SOLR-5211:
------------------------------------

I attached a patch for documentation.  It updates SolrClient deleteById calls 
to note it doesn't work on child IDs.  I also added a note to the ref guide for 
XML & JSON.  The JSON side diff might suggest I replaced different text but 
that same text was duplicated with previous text a few lines up.

In the CHANGES.txt I added a new "Upgrade Notes" section while leaving the 
other "Improvement" issue reference mostly unchanged.  I'll post this addition 
here to ensure you all can see:
{noformat}
* SOLR-5211: Deleting (or updating) documents by their uniqueKey is now scoped 
to only consider root documents, not
  child/nested documents.  Thus a delete-by-id won't work on a child doc 
(no-op), and an attempt to update a child doc
  by providing a new doc with the same ID would add a new doc (probably 
erroneous).  Both these actions were and still
  are problematic.  In-place-updates are safe though.  If you want to delete 
certain child documents and if you know
  they don't themselves have nested children then you must do so with a 
delete-by-query technique.
{noformat}

> updating parent as childless makes old children orphans
> -------------------------------------------------------
>
>                 Key: SOLR-5211
>                 URL: https://issues.apache.org/jira/browse/SOLR-5211
>             Project: Solr
>          Issue Type: Sub-task
>          Components: update
>    Affects Versions: 4.5, 6.0
>            Reporter: Mikhail Khludnev
>            Assignee: David Smiley
>            Priority: Blocker
>             Fix For: 8.0
>
>         Attachments: SOLR-5211.patch, SOLR-5211.patch, SOLR-5211.patch, 
> SOLR-5211.patch, SOLR-5211.patch, SOLR-5211_docs.patch
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> if I have parent with children in the index, I can send update omitting 
> children. as a result old children become orphaned. 
> I suppose separate \_root_ fields makes much trouble. I propose to extend 
> notion of uniqueKey, and let it spans across blocks that makes updates 
> unambiguous.  
> WDYT? Do you like to see a test proves this issue?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to