[ https://issues.apache.org/jira/browse/LUCENE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johannes Kloos closed LUCENE-8667. ---------------------------------- Invalid issue, should have been submitted to SOLR instead. > NPE due to missing input checking in ValueSourceParser > ------------------------------------------------------ > > Key: LUCENE-8667 > URL: https://issues.apache.org/jira/browse/LUCENE-8667 > Project: Lucene - Core > Issue Type: Bug > Components: core/search > Affects Versions: master (9.0) > Environment: h1. Steps to reproduce > * Use a Linux machine. > * Build commit {{ea2c8ba}} of Solr as described in the section below. > * Build the films collection as described below. > * Start the server using the command {{./bin/solr start -f -p 8983 -s > /tmp/home}} > * Request the URL given in the bug description. > h1. Compiling the server > {noformat} > git clone https://github.com/apache/lucene-solr > cd lucene-solr > git checkout ea2c8ba > ant compile > cd solr > ant server > {noformat} > h1. Building the collection > We followed [Exercise > 2|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html#exercise-2] from > the [Solr > Tutorial|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html]. The > attached file ({{home.zip}}) gives the contents of folder {{/tmp/home}} that > you will obtain by following the steps below: > {noformat} > mkdir -p /tmp/home > echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > > /tmp/home/solr.xml > {noformat} > In one terminal start a Solr instance in foreground: > {noformat} > ./bin/solr start -f -p 8983 -s /tmp/home > {noformat} > In another terminal, create a collection of movies, with no shards and no > replication, and initialize it: > {noformat} > bin/solr create -c films > curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field": > {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}' > http://localhost:8983/solr/films/schema > curl -X POST -H 'Content-type:application/json' --data-binary > '{"add-copy-field" : {"source":"*","dest":"_text_"}}' > http://localhost:8983/solr/films/schema > ./bin/post -c films example/films/films.json > {noformat} > Reporter: Johannes Kloos > Priority: Minor > Attachments: home.zip > > > Requesting the following URL causes Solr to return an HTTP 500 error response: > {noformat} > http://localhost:8983/solr/films/select?q={!frange%20l=10%20u=100}joindf(genre:comedy,$x) > {noformat} > The error response seems to be caused by the following uncaught exception: > {noformat} > java.lang.NullPointerException > at > org.apache.lucene.queries.function.valuesource.JoinDocFreqValueSource.hashCode(JoinDocFreqValueSource.java:98) > at > org.apache.solr.search.function.ValueSourceRangeFilter.hashCode(ValueSourceRangeFilter.java:139) > at > org.apache.solr.search.SolrConstantScoreQuery.hashCode(SolrConstantScoreQuery.java:138) > at org.apache.solr.search.QueryResultKey.<init>(QueryResultKey.java:46) > at > org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1328) > at org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:567) > at > org.apache.solr.handler.component.QueryComponent.doProcessUngroupedSearch(QueryComponent.java:1434) > at > org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:373) > [...] > {noformat} > As far as I can tell, the bug comes about as follows: > In org.apache.solr.search.ValueSourceParser, in the addParser(“joindf”, …) > statement (lines 335-342), we extract the arguments f0 and qf without > checking if these arguments could not be parsed. The test case produces a > null pointer for the qfield field in the JoinDocFreqValueSource instance. > This causes problems in hashcode (as evidenced in this bug), since it expects > qfield to be non-null. > Looking at the usages of qfield, it is generally expected to be non-null, so > it seems we are missing input validation in the parser. > We found this bug using [Diffblue Microservices > Testing|https://www.diffblue.com/labs/]. Find more information on this [fuzz > testing > campaign|https://www.diffblue.com/blog/2018/12/19/diffblue-microservice-testing-a-sneak-peek-at-our-early-product-and-results]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org