moshebla commented on a change in pull request #549: WIP:SOLR-13129 URL: https://github.com/apache/lucene-solr/pull/549#discussion_r252301619
########## File path: solr/solr-ref-guide/src/json-facet-api.adoc ########## @@ -664,7 +664,7 @@ NOTE: While a `query` domain can be combined with an additional domain `filter`, === Block Join Domain Changes -When a collection contains <<uploading-data-with-index-handlers.adoc#nested-child-documents, Block Join child documents>>, the `blockChildren` or `blockParent` domain options can be used transform an existing domain containing one type of document, into a domain containing the documents with the specified relationship (child or parent of) to the documents from the original domain. Review comment: Would changing blockChildren and blockParents to nestedChildren and nestedParents also be in scope? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
