[ 
https://issues.apache.org/jira/browse/LUCENE-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758256#comment-16758256
 ] 

Lucene/Solr QA commented on LUCENE-8655:
----------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  5s{color} 
| {color:red} LUCENE-8655 does not apply to master. Rebase required? Wrong 
Branch? See 
https://wiki.apache.org/lucene-java/HowToContribute#Contributing_your_work for 
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8655 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12957141/LUCENE-8655.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-LUCENE-Build/160/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> No possibility to access to the underlying "valueSource" of a 
> FunctionScoreQuery 
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-8655
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8655
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.6
>            Reporter: Gérald Quaire
>            Priority: Major
>              Labels: patch
>         Attachments: LUCENE-8655.patch
>
>
> After LUCENE-8099, the "BoostedQuery" is deprecated by the use of the 
> "FunctionScoreQuery". With the BoostedQuery, it was possible to access at its 
> underlying "valueSource". But it is not the case with the class 
> "FunctionScoreQuery". It has got only a getter for the wrapped query,  
> For development of specific parsers, it would be necessary to access the 
> valueSource of a "FunctionScoreQuery". I suggest to add a new getter into the 
> class "FunctionScoreQuery" like below:
> {code:java}
>  /**
>    * @return the wrapped Query
>    */
>   public Query getWrappedQuery() {
>     return in;
>   }
>  /**
>    * @return the a source of scores
>    */
>   public DoubleValuesSource getValueSource() {
>     return source;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to