[
https://issues.apache.org/jira/browse/SOLR-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758826#comment-16758826
]
Mark Miller commented on SOLR-13189:
------------------------------------
{quote}i guess i was just hoping for a less complicated
{quote}
I give the least complicated way:
{quote}More practically, the changed behavior mostly affects us injecting
fails. That type of test should be isolated and have correct checking. For the
rest of the tests, we probably don't expect fails and so failing if we have
them seems fine, something likely needs to be fixed or you are checking wrong.
{quote}
We should only inject fails on tests specifically designed for that, not
generally across tests. That should have worked with the http recovery call,
but it doesn't anymore.
Also, while that patch is a hack, it's also towards the direction we need to
move anyway. We need to change all the old style Solr cloud tests to work how I
changed that check consistency method (it just needs to be done in non hacking
way). Then we can move all those tests to the more modern solrcloud test base
class.
The main thing stopping that has been our use of those Jetty instance maps - we
need to drop that stuff.
> Need reliable example (Test) of how to use TestInjection.failReplicaRequests
> ----------------------------------------------------------------------------
>
> Key: SOLR-13189
> URL: https://issues.apache.org/jira/browse/SOLR-13189
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Priority: Major
> Attachments: SOLR-13189.patch, SOLR-13189.patch, SOLR-13189.patch
>
>
> We need a test that reliably demonstrates the usage of
> {{TestInjection.failReplicaRequests}} and shows what steps a test needs to
> take after issuing updates to reliably "pass" (finding all index updates that
> succeeded from the clients perspective) even in the event of an (injected)
> replica failure.
> As things stand now, it does not seem that any test using
> {{TestInjection.failReplicaRequests}} passes reliably -- *and it's not clear
> if this is due to poorly designed tests, or an indication of a bug in
> distributed updates / LIR*
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
