iverase commented on a change in pull request #569: LUCENE-8687: Optimise radix
partitioning for points on heap
URL: https://github.com/apache/lucene-solr/pull/569#discussion_r255052024
##########
File path:
lucene/core/src/java/org/apache/lucene/util/bkd/BKDRadixSelector.java
##########
@@ -82,30 +82,40 @@ public BKDRadixSelector(int numDim, int bytesPerDim, int
maxPointsSortInHeap, Di
* the split happens. The method destroys the original writer.
*
*/
- public byte[] select(PointWriter points, PointWriter left, PointWriter
right, long from, long to, long partitionPoint, int dim) throws IOException {
+ public byte[] select(PathSlice points, PathSlice[] slices, long from, long
to, long partitionPoint, int dim, int dimCommonPrefix) throws IOException {
Review comment:
I have relaxed the condition and it should be bigger than 1. Javadocs added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
