iverase commented on a change in pull request #578: LUCENE-8699: Use fixed byte array in HeapPointWriter URL: https://github.com/apache/lucene-solr/pull/578#discussion_r258392181
########## File path: lucene/core/src/java/org/apache/lucene/util/bkd/PointWriter.java ########## @@ -32,9 +32,12 @@ /** Add a new point from byte array*/ void append(byte[] packedValue, int docID) throws IOException; - /** Add a new point from byteRef */ + /** Add a new point from byteRef and docId */ Review comment: I have added a new interface called `PointValue` to abstract out the different formats for on-heap and offline points. The side-effect is that I left the interface method `void append(byte[] packedValue, int docID)` as this is used when we initially populate the BKDWriter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
