s1monw commented on a change in pull request #578: LUCENE-8699: Use fixed byte
array in HeapPointWriter
URL: https://github.com/apache/lucene-solr/pull/578#discussion_r258416319
##########
File path:
lucene/core/src/java/org/apache/lucene/util/bkd/BKDRadixSelector.java
##########
@@ -135,33 +133,37 @@ private int
findCommonPrefixAndHistogram(OfflinePointWriter points, long from, l
try (OfflinePointReader reader = points.getReader(from, to - from,
offlineBuffer)) {
assert commonPrefixPosition > dimCommonPrefix;
reader.next();
- reader.packedValueWithDocId(bytesRef);
+ PointValue pointValue = reader.pointValue();
// copy dimension
- System.arraycopy(bytesRef.bytes, bytesRef.offset + offset, scratch, 0,
bytesPerDim);
+ BytesRef packedValue = pointValue.packedValue();
+ System.arraycopy(packedValue.bytes, packedValue.offset + offset,
scratch, 0, bytesPerDim);
// copy docID
- System.arraycopy(bytesRef.bytes, bytesRef.offset + packedBytesLength,
scratch, bytesPerDim, Integer.BYTES);;
+ BytesRef docIDBytes = pointValue.docIDBytes();
+ System.arraycopy(docIDBytes.bytes, docIDBytes.offset, scratch,
bytesPerDim, Integer.BYTES);;
Review comment:
two training `;;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
