s1monw commented on a change in pull request #581: LUCENE-3041: QueryVisitor URL: https://github.com/apache/lucene-solr/pull/581#discussion_r258504519
########## File path: lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java ########## @@ -122,6 +123,18 @@ public Query rewrite(IndexReader reader) throws IOException { return super.rewrite(reader); } + @Override + public void visit(QueryVisitor visitor) { + visitor.visitLeaf(this, field, () -> { Review comment: why isn't this just calling the visitor with the individual terms? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org