+1, please open an issue. Seems like an oversight/bug.

On Thu, Feb 21, 2019 at 3:46 PM Jan Høydahl <[email protected]> wrote:

> Hi,
>
> I was surprised that the HttpClusterStateProvider starts connecting to
> Solr already
> in the constructor and not when cluster state is first requested, using
> the connect() method.
> The connect() method from ClusterStateProvider interface is implemented
> with an empty body.
>
> Risking that the constructor throws an exception e.g. due to timing issues
> makes it harder
> to implement graceful handling of connectivity issues. If the constructor
> would just initialize
> the urls, then you could separate connection retry issue handling in other
> parts of client code.
>
> If you agree, I'll open an issue to change this.
>
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com
>
>

Reply via email to