[ 
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775946#comment-16775946
 ] 

Erick Erickson commented on SOLR-13268:
---------------------------------------

At the last minute I put the conditional in StartupLoggingUtils.shutdown 
because precommit failed with "forbidden api" and I copied other similar 
patterns specific to log4j2. I wondered if we weren't calling shutdown for some 
reason, but apparently we are.

I checked, and the warning message that would print if we weren't running 
log4j2 is _NOT_ in the log, so apparently we are calling the log4j shutdown.

Upgrading to the latest certainly seems like A Good Thing. Since I can't get 
tests to fail (beasted 1,000 times) it seems like we'll have to push the 
changes up. I'll pull down your changes and run the test suites and if all that 
works do you want to push it or shall I?

And thanks a million for helping here...

> Clean up any test failures resulting from SOLR-12055 (async logging)
> --------------------------------------------------------------------
>
>                 Key: SOLR-13268
>                 URL: https://issues.apache.org/jira/browse/SOLR-13268
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So 
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set" 
> here, these are likely systemic, once the root cause is found/fixed, then 
> others are likely fixed as well.
> JDK13:
> ant test  -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV 
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test  -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk 
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to