dsmiley commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r260057419
##########
File path: lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java
##########
@@ -135,6 +138,20 @@ private boolean equalsTo(TermInSetQuery other) {
termData.equals(other.termData);
}
+ @Override
+ public void visit(QueryVisitor visitor) {
+ visitor.matchesAutomaton(this, field, true, this::toAutomaton);
Review comment:
maybe comment as to why this approach is taken vs looping through the terms.
I assume it's kind of a hint that avoids highlighting. BTW may want to put a
comment to https://issues.apache.org/jira/browse/LUCENE-3893 which is kinda
related and re-enforces the notion of TermInSetQuery as AutomatonQuery
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
