s1monw commented on a change in pull request #581: LUCENE-3041: QueryVisitor URL: https://github.com/apache/lucene-solr/pull/581#discussion_r260214115
########## File path: lucene/sandbox/src/java/org/apache/lucene/search/intervals/MinimumShouldMatchIntervalsSource.java ########## @@ -85,9 +85,14 @@ public MatchesIterator matches(String field, LeafReaderContext ctx, int doc) thr } @Override - public void extractTerms(String field, Set<Term> terms) { + public void visit(String field, QueryVisitor visitor) { + Query parent = new IntervalQuery(field, this); for (IntervalsSource source : sources) { - source.extractTerms(field, terms); + QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.SHOULD, parent); Review comment: pull only once? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org