romseygeek commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r260262309
##########
File path: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java
##########
@@ -284,6 +284,16 @@ public Query rewrite(IndexReader reader) throws
IOException {
}
}
+ @Override
+ public void visit(QueryVisitor visitor) {
+ for (Term term : terms) {
+ QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.MUST, this);
Review comment:
I took a shortcut :p
More seriously, I came across issues like this in Luwak when dealing with
super-massive queries, but I suppose there are other ways around it, like
throwing an exception or whatever. I can change it back to returning an empty
visitor if you really don't like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
