javanna commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r260300062
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/BoostQuery.java
 ##########
 @@ -104,6 +104,14 @@ public Query rewrite(IndexReader reader) throws 
IOException {
     return super.rewrite(reader);
   }
 
+  @Override
+  public void visit(QueryVisitor visitor) {
+    QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.MUST, this);
+    if (v != null) {
 
 Review comment:
   should you rather check for empty visitor here now? I guess we can assume 
that getSubVisitor never returns null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to