[
https://issues.apache.org/jira/browse/LUCENE-8671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785703#comment-16785703
]
Simon Willnauer commented on LUCENE-8671:
-----------------------------------------
I don't think we should add a setter to FieldInfo. This is a code-private thing
and should be treated this way. This looks like we need to have a way to pass
more info down when we open new SegmentReaders. I wonder if we can accept a
simple Map<String, String> on
{noformat}
public static DirectoryReader open(final IndexWriter writer, boolean
applyAllDeletes, boolean writeAllDeletes) throws IOException
{noformat}
We can then pass it down to the relevant parts and make it part of
`SegmentReaderState`? This map can also be passed via IndexWriterConfig for the
NRT case. That way we can pass stuff per DirectoryReader open which is what we
want I guess.
> Add setting for moving FST offheap/onheap
> -----------------------------------------
>
> Key: LUCENE-8671
> URL: https://issues.apache.org/jira/browse/LUCENE-8671
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/FSTs, core/store
> Reporter: Ankit Jain
> Priority: Minor
> Attachments: offheap_generic_settings.patch, offheap_settings.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> While LUCENE-8635, adds support for loading FST offheap using mmap, users do
> not have the flexibility to specify fields for which FST needs to be
> offheap. This allows users to tune heap usage as per their workload.
> Ideal way will be to add an attribute to FieldInfo, where we have
> put/getAttribute. Then FieldReader can inspect the FieldInfo and pass the
> appropriate On/OffHeapStore when creating its FST. It can support special
> keywords like ALL/NONE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
