[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789860#comment-16789860
]
Christine Poerschke commented on SOLR-13268:
--------------------------------------------
{quote}... hop in the way back machine and take a look at TestXmlQParser? ...
does it really do anything? Looks like a stub. ...
{quote}
Hi [~erickerickson]! TestXmlQParser – that's a trip down memory lane indeed.
* Yes, at first glance it looks like the test is just a stub.
* On second look though (and this could have been made clearer e.g. with class
level javadocs) the TestXmlQParser test extends the TestCoreParser test by
overriding the {{coreParser()}} method to return a {{SolrCoreParser}} instead
of a {{CoreParser}} parser. The test also inherits all the parent class's tests
and thus basically tests that whatever behaviour was present in the
{{CoreParser}} that same behaviour is also and still available via the
{{SolrCoreParser}} then.
{quote}... It relates to this JIRA, I have a reproducible seed on this test
class. I can fix it without too much trouble, but when I looked at this I
wondered if it shouldn't just be removed.
{quote}
Could you share details of what the reproducible failure is? I'd be curious
what it is. And yeah if it's not too much trouble to fix then it likely would
be worthwhile fixing IMHO.
> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
> Key: SOLR-13268
> URL: https://issues.apache.org/jira/browse/SOLR-13268
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13268.patch, SOLR-13268.patch, SOLR-13268.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set"
> here, these are likely systemic, once the root cause is found/fixed, then
> others are likely fixed as well.
> JDK13:
> ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
