[
https://issues.apache.org/jira/browse/SOLR-12589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793363#comment-16793363
]
Lucene/Solr QA commented on SOLR-12589:
---------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to SOLR's
naming conventions. Please see
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for
instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} SOLR-12589 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file for help.
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12589 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12933304/SOLR-12589-3.diff |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/338/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> metrics name should not contains "/" path seperator while using
> SolrGangliaReporter
> -----------------------------------------------------------------------------------
>
> Key: SOLR-12589
> URL: https://issues.apache.org/jira/browse/SOLR-12589
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: 7.3.1, 7.4, 8.0
> Reporter: weizhenyuan
> Priority: Minor
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-12589-1.diff, SOLR-12589-2.diff, SOLR-12589-3.diff
>
>
> As I was using SolrGangliaReporter, default metrics names will contains
> "/", which is
> offen used in FileSystem as an seperator, than it encounters ERROR cause
> creating
> metrics data file failed, bellow is the Exception in /var/log/messages:
> Jul 25 15:01:37 hb-bp1tg6t003y04p201-001 gmetad: Unable to write meta data
> for metric
> solr.node.QUERY.httpShardHandler.http_//hb-bp1tg6t003y04p201-003.hbase.rds.aliyuncs.com_8983/solr/admin/cores.post.requests.p999
> to RRD
> Jul 25 15:01:37 hb-bp1tg6t003y04p201-001 gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/cores.requestTimes.p999.rrd':
> No such file or directory
> Jul 25 15:01:37 hb-bp1tg6t003y04p201-001 gmetad: Unable to write meta data
> for metric solr.node.ADMIN./admin/cores.requestTimes.p999 to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/collections.requestTimes.min.rrd':
> No such file or directory
> Jul 25 15:01:37 localhost gmetad: Unable to write meta data for metric
> solr.node.ADMIN./admin/collections.requestTimes.min to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/authorization.requestTimes.stddev.rrd':
> No such file or directory
> Jul 25 15:01:37 localhost gmetad: Unable to write meta data for metric
> solr.node.ADMIN./admin/authorization.requestTimes.stddev to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.ADMIN./admin/autoscaling/history.requestTimes.p99.rrd':
> No such file or directory
> Jul 25 15:01:37 localhost gmetad: Unable to write meta data for metric
> solr.node.ADMIN./admin/autoscaling/history.requestTimes.p99 to RRD
> Jul 25 15:01:37 localhost gmetad: RRD_create: creating
> '/var/lib/ganglia/rrds/__SummaryInfo__/solr.node.QUERY./admin/autoscaling.timeouts.m1_rate.rrd':
> No such file or directory
> I think the metrics name should be normalized for different reporter，such as
> SolrGangliaReport.
> Some times other normalization is used for other reason，but now，for
> ganglia，It must
> replace the "/" .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
