[
https://issues.apache.org/jira/browse/SOLR-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798141#comment-16798141
]
Kevin Risden commented on SOLR-13335:
-------------------------------------
Velocity UI testing:
{code:java}
./bin/solr start -e techproducts
open http://localhost:8983/solr/techproducts/browse
# Clicked around a bunch
#checked logs for errors
grep -F ERROR ./example/techproducts/logs/solr.log
./example/techproducts/logs/solr-8983-console.log
./bin/solr stop -all
{code}
Here are the errors that occurred with the attached patch.
{code:java}
./example/techproducts/logs/solr.log:2019-03-21 14:23:56.052 ERROR
(qtp776700275-22) [ x:techproducts] o.a.v.rendering Left side
($list.size($request.params.getParams('fq'))) of comparison operation has null
value at VM_global_library.vm[line 36, column 102]
./example/techproducts/logs/solr.log:2019-03-21 14:23:56.049 ERROR
(qtp776700275-22) [ x:techproducts] o.a.v.rendering Left side
($list.size($p)) of comparison operation has null value at
VM_global_library.vm[line 44, column 88]
./example/techproducts/logs/solr.log:2019-03-21 14:23:56.050 ERROR
(qtp776700275-22) [ x:techproducts] o.a.v.rendering Left side
($collations.size()) of comparison operation has null value at
did_you_mean.vm[line 6, column 25]
{code}
For reference here are the errors from Solr 8.0 using the same test.
{code:java}
./example/techproducts/logs/solr.log:2019-03-21 14:32:54.262 ERROR
(qtp572593338-15) [ x:techproducts] o.a.s.r.VelocityResponseWriter Left side
($collations.size()) of '>' operation has null value at did_you_mean.vm[line 6,
column 25]
{code}
So there are 2 new errors. I'll see what it takes to fix all 3 though. Look
like they are of the same flavor.
> Upgrade to velocity 2.0 and velocity-tools 3.0
> ----------------------------------------------
>
> Key: SOLR-13335
> URL: https://issues.apache.org/jira/browse/SOLR-13335
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 8.1, master (9.0)
>
> Attachments: SOLR-13335.patch, SOLR-13335.patch, SOLR-13335.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As part of looking to remove old commons-lang in SOLR-9079, found that
> velocity depends on it. Upgrading Velocity would allow completely removing
> commons-lang
> Copy some detail from SOLR-9079 investigation:
> * solr/contrib/velocity/ivy.xml doesn't even reference commons-lang
> * velocity 1.7 was released - 2010-11-29
> * LUCENE-5249 from 2013 was the last time velocity was changed in
> lucene/ivy-versions.properties
> * velocity-tools 2.0 has an optional dependency on commons-lang
> * velocity 1.7 has a hard dependency on commons-lang.
> Upgrading velocity 1.7 -> 2.0
> * http://velocity.apache.org/engine/2.0/upgrading.html
> * Change velocity to velocity-engine-core
> * upgrades commons-lang to commons-lang3
> So if we want to finish removing commons-lang, we need to upgrade velocity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
