[ https://issues.apache.org/jira/browse/SOLR-13323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800337#comment-16800337 ]
Gus Heck commented on SOLR-13323: --------------------------------- commit message connfusion in ide... the following is for this ticket Commit cbaa68e9c0bad859d70ae4a8885bbecde6b79453 in lucene-solr's branch refs/heads/branch_8x from Gus Heck [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cbaa68e ] > Remove org.apache.solr.internal.csv.writer.CSVWriter (and related classes) > -------------------------------------------------------------------------- > > Key: SOLR-13323 > URL: https://issues.apache.org/jira/browse/SOLR-13323 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: master (9.0) > Reporter: Gus Heck > Priority: Minor > > This class appears to only be used in the test for itself. It's also easily > confused with org.apache.solr.response.CSVWriter > I propose we remove this class entirely. Is there any reason to believe from > it's past history (of which I know nothing) that it might be depended upon by > outside code and require a deprecation cycle? > Presently it contains a System.out.println and a eclipse generated catch > block that precommit won't like if we enable checking for System.out.println, > which is why this ticket is a sub-task. If we do need to deprecate it then I > propose we remove the print and simply re-throw the exception as a > RuntimeException -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org