dsmiley commented on issue #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#issuecomment-476854467 * The change to `DocTermOrds` appears to be erroneous related to getting up to date with master. Same for `the-terms-component.adoc` * AddUpdateCommand.getHashableId calls getRootIdUsingRouteParam which calls getHashableId -- seems like a recipe for an infinite loop. Even if it turns out to never happen, lets improve this. Just curious; what's your opinion on the refactor of DistributedUpdateProcessor? Did it help make your edits here bettor or worse or same? More feedback to follow... will run tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
