dsmiley commented on a change in pull request #455: SOLR-12638
URL: https://github.com/apache/lucene-solr/pull/455#discussion_r270084153
##########
File path:
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
##########
@@ -1032,6 +1151,24 @@ protected void assertNotFinished() {
finished = true;
}
+ /**
+ *
+ * @return whether this update changes a value of a block
+ */
+ public static boolean shouldRefreshUlogCaches(AddUpdateCommand cmd) {
Review comment:
Can we make this logic more efficient by adding a field to AddUpdateCommand
that declares (a) is this update an atomic update, and furthermore, did it
involve nested documents? Perhaps two separate `Boolean`s, null meaning not
yet calculated. By this juncture in the code I think we've already determined
these things and I'd like to avoid potential overhead per document going into
Solr. Lambda's can add up.
typo "update.q" => "update"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
