[ 
https://issues.apache.org/jira/browse/LUCENE-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809977#comment-16809977
 ] 

Uwe Schindler commented on LUCENE-2562:
---------------------------------------

Hi [~Tomoko Uchida],
I have noticed the change already! It looks fine. I will now do some tests, but 
according to my knowledge this looks fine. It's an antipattern to load every 
class on classpath and collect those that are a specific subclass, but 
unfortunately there is no way in Java to do this solely through classloaders 
(they don't allow to list classes). The code should work fine with Java 8 and 
11 and later, as long as Luke is shipped as a JAR file. Once we switch to Java 
module system this may change, but it's OK for now. I like the code to find the 
JAR files that have a package by doing a ClassLoader#getResource() and 
analyzing the URL.

I will do some tests on Lucene master (9.0) and if all looks fine, I can merge 
it soon. Do you have any other plans except adding the Netbeans/Exclipse files? 
I think Eclipse should work out of box (I will check this, trust me), but I 
have no idea about Netbeans&Co.

Uwe

> Make Luke a Lucene/Solr Module
> ------------------------------
>
>                 Key: LUCENE-2562
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2562
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Mark Miller
>            Assignee: Uwe Schindler
>            Priority: Major
>              Labels: gsoc2014
>         Attachments: LUCENE-2562-Ivy.patch, LUCENE-2562-Ivy.patch, 
> LUCENE-2562-Ivy.patch, LUCENE-2562-ivy.patch, LUCENE-2562.patch, 
> LUCENE-2562.patch, Luke-ALE-1.png, Luke-ALE-2.png, Luke-ALE-3.png, 
> Luke-ALE-4.png, Luke-ALE-5.png, luke-javafx1.png, luke-javafx2.png, 
> luke-javafx3.png, luke1.jpg, luke2.jpg, luke3.jpg, lukeALE-documents.png, 
> screenshot-1.png, スクリーンショット 2018-11-05 9.19.47.png
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> see
> "RE: Luke - in need of maintainer": 
> http://markmail.org/message/m4gsto7giltvrpuf
> "Web-based Luke": http://markmail.org/message/4xwps7p7ifltme5q
> I think it would be great if there was a version of Luke that always worked 
> with trunk - and it would also be great if it was easier to match Luke jars 
> with Lucene versions.
> While I'd like to get GWT Luke into the mix as well, I think the easiest 
> starting point is to straight port Luke to another UI toolkit before 
> abstracting out DTO objects that both GWT Luke and Pivot Luke could share.
> I've started slowly converting Luke's use of thinlet to Apache Pivot. I 
> haven't/don't have a lot of time for this at the moment, but I've plugged 
> away here and there over the past work or two. There is still a *lot* to do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to