[ https://issues.apache.org/jira/browse/LUCENE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820077#comment-16820077 ]
Lucene/Solr QA commented on LUCENE-8765: ---------------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 40s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 2m 3s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 32m 7s{color} | {color:green} core in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 39m 47s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-8765 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12966179/0001-Fix-OneDimensionBKDWriter-valueCount-validation.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / fb28958 | | ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/181/testReport/ | | modules | C: lucene/core U: lucene/core | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/181/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > OneDimensionBKDWriter valueCount validation didn't include leafCount > -------------------------------------------------------------------- > > Key: LUCENE-8765 > URL: https://issues.apache.org/jira/browse/LUCENE-8765 > Project: Lucene - Core > Issue Type: Bug > Components: core/other > Affects Versions: 7.5, master (9.0) > Reporter: ZhaoYang > Priority: Minor > Attachments: > 0001-Fix-OneDimensionBKDWriter-valueCount-validation.patch > > > {{[OneDimensionBKDWriter#add|https://github.com/jasonstack/lucene-solr/blob/branch_7_5/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java#L612]}} > checks if {{valueCount}} exceeds predefined {{totalPointCount}}, but > {{valueCount}} is only updated for every > 1024({{DEFAULT_MAX_POINTS_IN_LEAF_NODE}}) points. > We should include {{leafCount}} for validation. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org