diegoceccarelli commented on a change in pull request #162: SOLR-8776: Support
RankQuery in grouping
URL: https://github.com/apache/lucene-solr/pull/162#discussion_r278121455
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -1270,7 +1270,7 @@ private void
doProcessGroupedDistributedSearchFirstPhase(ResponseBuilder rb, Que
final int topNGroups;
Query query = cmd.getQuery();
if (query instanceof AbstractReRankQuery){
- topNGroups = cmd.getOffset() +
((AbstractReRankQuery)query).getReRankDocs();
+ topNGroups = Math.max(((AbstractReRankQuery)query).getReRankDocs(),
cmd.getOffset() + cmd.getLen());
Review comment:
You were right, I added a unit test and it is failing :/ I'm working on it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
