ctargett commented on issue #653: SOLR-13425: Wrong color in horizontal definition list URL: https://github.com/apache/lucene-solr/pull/653#issuecomment-486262130 Good catch, thanks. This is caused by the customized HTML templates I introduced in SOLR-12746 (7.6). Where the 1st column of that style of horizontal list used to be in a `td` tag, now it's in a `th` tag. An alternate change that would ensure that style of list always looks exactly the way it did before would be to modify the template at https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/_templates/_hdlist.html.slim#L9 to just change: ```th.hdlist1 class=('strong' if option? 'strong')``` to ```td.hdlist1 class=('strong' if option? 'strong')``` This would prevent us from possibly finding other things we have to fix in the CSS later on. What do you think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
