[ https://issues.apache.org/jira/browse/SOLR-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837613#comment-16837613 ]
ASF subversion and git services commented on SOLR-13454: -------------------------------------------------------- Commit 4c10edc3e469aad0d72ace6b785441d6d8c2c021 in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4c10edc ] SOLR-13454: Investigate ReindexCollectionTest failures. I missed a place where I should have called the bandaid code (cherry picked from commit 0aaf5432089075cf3847508ae83de76ee5e44b97) > Investigate ReindexCollectionTest failures > ------------------------------------------ > > Key: SOLR-13454 > URL: https://issues.apache.org/jira/browse/SOLR-13454 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Minor > > This _looks_ like it might be another example of commits not quite happening > correctly, see > SOLR-11035. Problem is I can’t get it to fail locally after 2,000 iterations. > So I’m going to add a bit to the bandaid to allow tests to conditionally fail > if the bandaid would have made it pass. That way we can positively detect > that the bandaid is indeed the case rather than change code and hope. > This _shouldn’t_ add any noise to the Jenkins lists, as the test won’t fail > in cases where it didn’t before. > In case people wonder what the heck I’m doing. > BTW, if we ever really understand/fix the underlying cause, we should make > the bandaid code fail and see, then remove it if so. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org