madrob commented on a change in pull request #666: SOLR-13437: fork noggit code into Solr URL: https://github.com/apache/lucene-solr/pull/666#discussion_r283883440
########## File path: solr/solrj/src/java/org/apache/solr/common/json/ObjectBuilder.java ########## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more Review comment: Modify content? Yes. Remove copyright? No. ALv2 section 4c states: >You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works; and That pretty clearly reads to me like the copyright attribution has to stay with the source. Section 4d goes on to state that we only have to carry forward content in NOTICE if the original source has a NOTICE (which this doesn't), so I think that was a misread on my part earlier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
