janhoy commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-493064161 There is stil a TON of unrelated whitespace changes in the patch. If you want to reformat code, best practice is to open another PR for that separately. What I normally do to clean up is first disable the aggressive reformatting feature in the IDE, then open "Compare with branch ..." in my IDE (IntelliJ) and in the diff view, click restore on every single diff change that is messed up by the IDE, then commit and push those changes. You'll then see that your diff becomes MUCH smaller and easier to read!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
