thomaswoeckinger commented on issue #665: Fixes SOLR-11841, SOLR-13331, SOLR-13347 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-493093718 Is it better for you if put the formatting in an seperate commit, i think if i create a new pr this will never get merged, otherwise the format would not be in the current state. Jan Høydahl <notificati...@github.com> schrieb am Do., 16. Mai 2019, 15:19: > There is stil a TON of unrelated whitespace changes in the patch. If you > want to reformat code, best practice is to open another PR for that > separately. > > What I normally do to clean up is first disable the aggressive > reformatting feature in the IDE, then open "Compare with branch ..." in my > IDE (IntelliJ) and in the diff view, click restore on every single diff > change that is messed up by the IDE, then commit and push those changes. > You'll then see that your diff becomes MUCH smaller and easier to read! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene-solr/pull/665?email_source=notifications&email_token=ACKCGQEYP7AEC5CH64ZIUB3PVVNPJA5CNFSM4HLKBL4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRY7YI#issuecomment-493064161>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACKCGQAVP6KGSZBUSHKBPRLPVVNPJANCNFSM4HLKBL4A> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
