[ https://issues.apache.org/jira/browse/SOLR-13474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841493#comment-16841493 ]
David Smiley commented on SOLR-13474: ------------------------------------- +1 -- but hopefully [~noble.paul] can review too. Thanks so much for both investigating and fixing all these bugs introduced by SOLR-12999. I wish it had a code review. > Fix "Search is temporarily disabled" logic to be consistent for entire request > ------------------------------------------------------------------------------ > > Key: SOLR-13474 > URL: https://issues.apache.org/jira/browse/SOLR-13474 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Hoss Man > Priority: Major > Attachments: SOLR-13474.patch > > > Where/How the "Search is temporarily disabled" logic was added in SOLR-12999 > can result in some weird failure cases (examples: SOLR-13470 & SOLR-13471) > due to the fact that (as currently implemented) some portions of processing > a SolrQueryRequest may see a valid searcher, but later other code paths will > get an error when trying to use the same searcher. > I think it would make more sense to move the "searchEnabled" logic out of > {{SolrQueryRequestbase.getSearcher()}} and into {{SolrCore.getSearcher()}} > (removing the need for {{SolrCore.isSearchEnabled()}} ). > This will: > * restore the long standing (and widly assumed by code) behavior of > {{SolrQueryRequestbase.getSearcher()}} that it will always return a > consistent result > * ensure that any custom plugins trying to call {{SolrCore.getSearcher()}} > directly will also get the benefits of the safety checks introduced in > SOLR-12999 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org